feat: add resolved_round to comments (mirror crit timeline)#175
Merged
tomasz-tomczyk merged 2 commits intomainfrom May 5, 2026
Merged
feat: add resolved_round to comments (mirror crit timeline)#175tomasz-tomczyk merged 2 commits intomainfrom
tomasz-tomczyk merged 2 commits intomainfrom
Conversation
Stamp resolved_round with the review's current review_round on false → true transitions; clear to nil on true → false. Mirrors crit's round-faithful timeline so /api/reviews/:token consumers can filter resolution state per round. The field is nullable (NULL = never/currently unresolved). Threaded through CLI share imports and surfaced in API + export payloads. Closes #173
Adds a test-only POST /api/reviews/:token/seed-resolve/:comment_id endpoint so the crit ↔ crit-web share integration suite can exercise the resolve/unresolve flow end-to-end and assert the resolved_round contract surfaced in the public API. Extends api_controller_test to verify resolved_round round-trips through POST /reviews and the export endpoint.
3 tasks
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (35.29%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 79.56% 79.14% -0.43%
==========================================
Files 56 56
Lines 1801 1817 +16
==========================================
+ Hits 1433 1438 +5
- Misses 368 379 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolved_round(nullable integer) to thecommentstable to mirror crit's round-faithful timeline data modelfalse → true), stamps the review's currentreview_round; on unresolve (true → false), clears tonilreplace_comments,create_changeset) and surfaces it in API + export payloadsnullsemantics: absent = never/currently unresolved; integer = resolved at round NReview
session.go:909,comment_cli.go:78)TestShareSyncResolvedRoundMapping(crit) + extendedapi_controller_test(crit-web)Test plan
Reviews.resolve_comment/4tests for stamp/clear;seed-resolvetest endpoint exercised by crit's share integration suiteCloses #173
🤖 Generated with Claude Code