test: integration coverage for resolved_round mapping#467
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 5, 2026
Merged
test: integration coverage for resolved_round mapping#467tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
Adds TestShareSyncResolvedRoundMapping to share_integration_test.go, verifying that crit-web stamps resolved_round with the review's current review_round on resolve, clears it on unresolve, and that both fields round-trip through the public API that crit reads. Threads ResolvedRound through webComment so future pull paths can consume it. Also fixes the writeTestCritJSON helper (and one inline writer) to use the v4 review-folder layout (.crit/review.json) so multiple already-broken share integration tests run again.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
+ Coverage 69.04% 69.06% +0.02%
==========================================
Files 36 36
Lines 10698 10698
==========================================
+ Hits 7386 7389 +3
+ Misses 2748 2746 -2
+ Partials 564 563 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestShareSyncResolvedRoundMappingend-to-end across crit ↔ crit-web — verifies stamp on resolve, clear on unresolve, and round-trip via the public APIResolvedRoundthroughwebCommentso future pull paths (and current tests) can consume itwriteTestCritJSONhelper to use the v4 review-folder layout (.crit/review.json) — several share integration tests were already broken on main; this restores themReview
go test -race ./...cleangolangci-lint run ./...cleanTest plan
make e2e-shareagainst feat: add resolved_round to comments (mirror crit timeline) crit-web#175 — all greenseed-resolveendpoint and the resolved_round model)🤖 Generated with Claude Code