fix: confirm before discarding non-empty comment drafts on Esc#157
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 1, 2026
Merged
fix: confirm before discarding non-empty comment drafts on Esc#157tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
Pressing Esc on a comment form with content now prompts a native
confirm("Discard comment?") so a detailed draft isn't lost in one
keystroke. Empty forms still close silently. The Cancel button is an
explicit, labeled discard and is intentionally not gated. Applies to
new comments, edits, and reply edits.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 77.28% 77.28%
=======================================
Files 55 55
Lines 1651 1651
=======================================
Hits 1276 1276
Misses 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discard comment?instead of silently throwing away the draft. Empty form → silent close (unchanged).Test plan
🤖 Generated with Claude Code