fix: confirm before discarding non-empty comment draft on Escape#415
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 1, 2026
Merged
fix: confirm before discarding non-empty comment draft on Escape#415tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
Pressing Escape on a comment form silently threw away whatever was in
the textarea. After typing a long comment, a single fat-fingered Esc
would lose it.
Now, if the form's textarea has any non-whitespace content, Escape
surfaces a native window.confirm("Discard comment?"). Empty forms close
silently as before. The Cancel button is left untouched — it's an
explicit, labeled discard action and matches GitHub's behavior.
Programmatic close paths (closeEmptyForms / closeEmptyReviewForm after a
successful submit) bypass the prompt because they only fire when the
textarea is already empty.
Esc gating is applied at:
- Esc inside textarea (createCommentFormUI's bindSubmitCancelKeys path)
- Esc with no textarea focus (top-level keydown switch)
Both inline-comment forms and the review-level comment form are covered.
Reply textarea Esc was already correct (only collapses when empty).
E2E coverage:
- 3 new keyboard.spec.ts tests: Esc cancel/accept dialog flow,
Cancel-button silent discard (no dialog), empty-form silent close
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 67.29% 67.30% +0.01%
==========================================
Files 26 26
Lines 9668 9668
==========================================
+ Hits 6506 6507 +1
+ Misses 2652 2651 -1
Partials 510 510
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discard comment?instead of silently throwing away the draft. Empty form → silent close (unchanged).Test plan
go build+go test ./...clean.🤖 Generated with Claude Code