fix: require c keypress to comment on selection#151
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 1, 2026
Merged
Conversation
Mirrors crit/#408 fix: text selection alone no longer hijacks copy by opening the comment form. Now the user must press `c` after selecting text to open the comment form (with the selection captured as a quote). This builds on the existing `c` shortcut for "comment on focused block". Pressing `c` with no active selection falls back to the focused-block behavior. With a selection, it opens a comment form anchored to the selection's line range with the selected text saved as the quote. The shortcuts panel is updated to reflect the new behavior. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 77.37% 77.37%
=======================================
Files 55 55
Lines 1653 1653
=======================================
Hits 1279 1279
Misses 374 374
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cafter selecting opens a comment form anchored to the selection's line range, with the selected text saved as a quotecwithout a selection falls back to its existing focused-block behaviorMirrors the parity fix in tomasz-tomczyk/crit#411.
Test plan
🤖 Generated with Claude Code