fix: require c keypress to comment on selection (#408)#411
Merged
tomasz-tomczyk merged 1 commit intomainfrom May 1, 2026
Merged
fix: require c keypress to comment on selection (#408)#411tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
Selecting text used to immediately open the comment editor, hijacking copy. Now selection alone leaves the page selection untouched (so users can copy normally) and the existing `c` shortcut is extended: when text is selected, pressing `c` opens a comment form anchored to that line range with the selection captured as a quote. With no selection, `c` falls back to its existing behavior of commenting on the focused block. The shortcuts panel is updated to reflect the new behavior. Closes #408 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
+ Coverage 67.26% 67.29% +0.03%
==========================================
Files 26 26
Lines 9650 9650
==========================================
+ Hits 6491 6494 +3
+ Misses 2649 2647 -2
+ Partials 510 509 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cafter selecting opens a comment form anchored to the selection's line range, with the selected text saved as a quotecwithout a selection falls back to its existing focused-block behaviorCloses #408
See also: tomasz-tomczyk/crit-web#151 (parity)
Test plan
🤖 Generated with Claude Code