ci: fix invalid codecov.yml so status checks wait for upload#146
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 30, 2026
Merged
ci: fix invalid codecov.yml so status checks wait for upload#146tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
after_n_builds is not a valid field under coverage.status.project.default or coverage.status.patch.default. Without a valid codecov.notify config, status checks fire as soon as the first upload arrives, against the base commit's data — leading to misleading early "failure" reports. Add codecov.notify.after_n_builds: 1 + wait_for_ci: true so the status waits for CI to complete before reporting. Validated via https://codecov.io/validate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 77.13% 77.13%
=======================================
Files 54 54
Lines 1636 1636
=======================================
Hits 1262 1262
Misses 374 374
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
after_n_buildsis not valid undercoverage.status.project.default/coverage.status.patch.default— without a validcodecov.notifyblock, status checks fire as soon as the first upload arrives, against the base commit's data, leading to misleading early "failure" reportscodecov.notify.after_n_builds: 1+wait_for_ci: trueso the status waits for CI to complete before reportingTest plan
curl -X POST --data-binary @codecov.yml https://codecov.io/validatereturnsValid!See also: tomasz-tomczyk/crit#402 (same fix)
🤖 Generated with Claude Code