ci: fix invalid codecov.yml so status checks wait for all uploads#402
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 30, 2026
Merged
ci: fix invalid codecov.yml so status checks wait for all uploads#402tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
after_n_builds is not a valid field under coverage.status.project.default or coverage.status.patch.default. Codecov was rejecting the whole YAML and falling back to defaults, firing patch/project checks on the first upload — before the ~7min e2e job's coverage landed. Resulting checks reported a ~4% drop that auto-corrected once both uploads arrived. Move after_n_builds: 2 + wait_for_ci: true to codecov.notify (the only valid location) so checks hold until both unit and e2e uploads land. Also drop the malformed flags: block — both unit and e2e had identical exclusion-only paths, ignore: already excludes frontend/ and e2e/. Validated via https://codecov.io/validate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 67.08% 67.09% +0.01%
==========================================
Files 19 19
Lines 8221 8221
==========================================
+ Hits 5515 5516 +1
+ Misses 2277 2276 -1
Partials 429 429
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
after_n_buildsis not valid undercoverage.status.project.default/coverage.status.patch.default— codecov was rejecting the whole YAML and falling back to defaults, firing patch/project checks immediately on the first upload (before the ~7min e2e coverage upload landed)after_n_builds: 2+wait_for_ci: truetocodecov.notify(the only valid location)flags:block (both flags had identical exclusion-only paths;ignore:already coversfrontend/ande2e/)Test plan
curl -X POST --data-binary @codecov.yml https://codecov.io/validatereturnsValid!See also: tomasz-tomczyk/crit-web#146 (same fix)
🤖 Generated with Claude Code