fix: auto-close empty comment forms when opening another#124
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 26, 2026
Merged
fix: auto-close empty comment forms when opening another#124tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
Opening a new comment form now closes other open forms that are empty (forms with text or in-edit are kept). Adds regression test for reply form collapse-after-submit (already correct in this repo). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
=======================================
Coverage 75.87% 75.87%
=======================================
Files 52 52
Lines 1513 1513
=======================================
Hits 1148 1148
Misses 365 365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
tomasz-tomczyk
added a commit
that referenced
this pull request
Apr 26, 2026
) Parity port from crit/ PR #366. closeEmptyForms was already wired into openForm (line-scope) via PR #124, but the file-scope and review-scope paths (openFileCommentForm / openReviewCommentForm) were missed. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review
Test plan
e2e/comments.spec.ts— empty form closes on new form open; non-empty stayse2e/threading.spec.ts— reply collapses after submitSee also: tomasz-tomczyk/crit#366
🤖 Generated with Claude Code