Skip to content

fix: hide comment line highlight when 'h' hides resolved comments#123

Merged
tomasz-tomczyk merged 1 commit intomainfrom
hide-comment-line-highlight
Apr 26, 2026
Merged

fix: hide comment line highlight when 'h' hides resolved comments#123
tomasz-tomczyk merged 1 commit intomainfrom
hide-comment-line-highlight

Conversation

@tomasz-tomczyk
Copy link
Copy Markdown
Owner

@tomasz-tomczyk tomasz-tomczyk commented Apr 26, 2026

Summary

  • Resolved comments' line-range highlight now tracks card visibility: hidden when the h toggle is on, visible when off.
  • Previously, the highlight stayed regardless of toggle state.

Review

  • Code review: passed
  • Parity audit: passed (mirrors crit/ change)

Test plan

  • Add a resolved comment, press h — both card and line highlight hide together
  • Press h again — both reappear
  • Toggle from settings pane — same behavior

See also: tomasz-tomczyk/crit#365

🤖 Generated with Claude Code

Resolved comments' line-range highlight now tracks card visibility:
the highlight disappears with the card when the hide-resolved toggle
is on, and reappears when off. Previously the highlight stayed
regardless of toggle state.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.87%. Comparing base (818ad8d) to head (e1efc66).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   75.87%   75.87%           
=======================================
  Files          52       52           
  Lines        1513     1513           
=======================================
  Hits         1148     1148           
  Misses        365      365           
Flag Coverage Δ
unit 75.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tomasz-tomczyk tomasz-tomczyk merged commit c44f009 into main Apr 26, 2026
4 checks passed
@tomasz-tomczyk tomasz-tomczyk deleted the hide-comment-line-highlight branch April 26, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant