fix: hide comment line highlight when 'h' hides resolved comments#365
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 26, 2026
Merged
fix: hide comment line highlight when 'h' hides resolved comments#365tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
Resolved comments' line-range highlight now tracks card visibility: the highlight disappears with the card when the hide-resolved toggle is on, and reappears when off. Previously the unified diff view kept the highlight regardless, and the document/split views never rendered the highlight for resolved comments — both inconsistent with the toggle. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 66.86% 66.90% +0.03%
==========================================
Files 18 18
Lines 7807 7807
==========================================
+ Hits 5220 5223 +3
+ Misses 2194 2192 -2
+ Partials 393 392 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
htoggle is on, visible when off.Review
Test plan
h— both card and line highlight hide togetherhagain — both reappearSee also: tomasz-tomczyk/crit-web#123
🤖 Generated with Claude Code