test: integration test for review-level reply round-trip#407
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 30, 2026
Merged
test: integration test for review-level reply round-trip#407tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
Adds TestShareSyncFetchReviewLevelReplies — seeds a review-level (general/doc-anchored) comment on crit-web, replies twice from the web side, re-shares to trigger a fetch, and verifies both replies round-trip into local ReviewComments with author preserved. Complements the existing TestShareSyncFetchReplies (line-anchored) and TestShareSyncFetchReviewLevelWebComment (review-level body without replies). Locks the parity gap surfaced when crit-web's review-level cards were missing the reply UI even though the API worked — the share integration tests had been passing all along because they exercise the API directly, not the UI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 67.05% 67.12% +0.06%
==========================================
Files 19 19
Lines 8221 8221
==========================================
+ Hits 5513 5518 +5
+ Misses 2278 2275 -3
+ Partials 430 428 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds `TestShareSyncFetchReviewLevelReplies` to the share integration suite. The test seeds a review-level comment on crit-web, adds two replies from the web side, re-shares to trigger a fetch, and verifies both replies land in local `ReviewComments` with author preserved.
Why
This locks the parity gap that surfaced today: crit-web's review-level cards were missing the reply UI even though the LiveView `add_reply` handler is generic and the API round-trip worked. The existing `TestShareSyncFetchReplies` covers line-anchored replies; `TestShareSyncFetchReviewLevelWebComment` covers a review-level body without replies. Neither caught the missing UI affordance.
This test wouldn't have caught the UI gap either (it's API-level), but it ensures the data path stays correct as we evolve the feature, and codifies "review-level replies must round-trip" as a tested invariant.
The crit-web UI fix landed in tomasz-tomczyk/crit-web#150.
Review
Test plan
🤖 Generated with Claude Code