fix: review conversation reply UI + always-centered layout#150
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 30, 2026
Merged
fix: review conversation reply UI + always-centered layout#150tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
Two parity gaps from #147 (closes crit/#374): 1. Review-level comment cards on crit-web didn't expose a reply input, only line-anchored cards did. Round-trip tests passed because they exercised the API directly. Adds renderReplyList + createReplyInput to the inline review-conversation card, matching the line-anchored render path. 2. crit-web has no git-mode equivalent — every review is doc-style. Drop the multi-file branch in renderReviewConversation and always set data-doc-layout="centered" so the Review conversation block centers consistently with the rest of the document. Adds a LiveView test that exercises the add_reply event end-to-end on a review-scope comment to lock the parity. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 77.37% 77.37%
=======================================
Files 55 55
Lines 1653 1653
=======================================
Hits 1279 1279
Misses 374 374
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why we missed it
The share integration tests in crit/ pass replies through the API directly (`POST /api/reviews/{token}/seed-reply`) — they verify the round-trip data path, not the UI affordance. The reply API worked; the button to trigger it from the web UI didn't exist.
Crit-side follow-up: a `TestShareSyncFetchRepliesOnReviewLevelComment` that exercises the full review→reply→fetch loop will land in a separate crit/ PR.
Review
Test plan
Refs:
🤖 Generated with Claude Code