Change comment submit button text to 'Add comment'#385
Merged
tomasz-tomczyk merged 1 commit intotomasz-tomczyk:mainfrom Apr 29, 2026
Conversation
Owner
|
I'd be okay with |
da49c27 to
b94cd01
Compare
Contributor
Author
|
Updated |
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 66.58% 66.62% +0.03%
==========================================
Files 19 19
Lines 8176 8176
==========================================
+ Hits 5444 5447 +3
+ Misses 2310 2308 -2
+ Partials 422 421 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tomasz-tomczyk
added a commit
to tomasz-tomczyk/crit-web
that referenced
this pull request
Apr 29, 2026
* fix: rename comment submit button to "Comment" Mirrors tomasz-tomczyk/crit#385 — clarifies that the button submits the comment, not the whole review. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test: update e2e tests for Comment button rename Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
|
Thank you! 🧡 💜 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When I write a comment, I need to press the "submit" button to submit my comment.
First time I've used it, I thought to myself "but I don't want to submit my review yet", and I think about it every time now 🙃
Can the button be renamed to "add comment", "comment", or something like that so it will feel like "I'm just done with this part, but not with the whole review"?
Thanks! :)