fix: hide TOC panel when buildToc has no headings#360
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
`hideToc()` only hid the toggle button, leaving the TOC panel visible if it was already open from a previous render with headings. Now `hideToc()` also adds `toc-hidden` to the panel so re-renders without headings (e.g. after round-complete on a file whose headings were removed) close the panel as well as the button. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
=======================================
Coverage ? 60.97%
=======================================
Files ? 18
Lines ? 7807
Branches ? 0
=======================================
Hits ? 4760
Misses ? 2619
Partials ? 428
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hideToc()only hid the toggle button. If the panel had been opened from a previous render where headings existed (or via cookie restore), a subsequentbuildToc()call with no headings would leave the panel visible but empty.hideToc()also addstoc-hiddento the panel.Test plan
e2e/tests/toc-refresh.singlefile.spec.ts:POST /api/round-complete→ both toggle button and panel are hidden.🤖 Generated with Claude Code