fix: hide TOC button and panel when document has no headings#113
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 25, 2026
Merged
fix: hide TOC button and panel when document has no headings#113tomasz-tomczyk merged 1 commit intomainfrom
tomasz-tomczyk merged 1 commit intomainfrom
Conversation
The table-of-contents toggle button was correctly hidden when a document had no headings, but the localStorage open-state restoration unconditionally removed the `crit-toc-hidden` class on wide viewports — leaving an empty TOC panel visible. Now buildToc adds the hidden class on the panel when items are empty, and the mount-time restoration only runs when items exist. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage ? 77.35%
=======================================
Files ? 50
Lines ? 1356
Branches ? 0
=======================================
Hits ? 1049
Misses ? 307
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildTocnow addscrit-toc-hiddento the panel when the heading list is empty, and the mount-time restoration only runs when there are items.Test plan
e2e/toc.spec.tscovers:localStorage["crit-toc"] = "open"pre-seeded🤖 Generated with Claude Code