refactor: unify CLI and browser share code paths#304
Merged
tomasz-tomczyk merged 1 commit intomainfrom Apr 18, 2026
Merged
Conversation
Replace the browser share path (buildShareFromSession) with the same disk-based approach used by `crit share` CLI. handleShare now reads file content from disk via LoadShareFilesFromDisk and comments from the review file via loadCommentsForShare, eliminating the buggy in-memory path that missed review comments and would need duplicated updates for future features like orphaned file support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildShareFromSession(the browser-only share path that read from in-memory session state)handleSharenow reads files from disk via newLoadShareFilesFromDisk()and comments from the review file vialoadCommentsForShare()— the same disk-based path the CLI usesWhat changed
share.go: RemovedbuildShareFromSession(-34 lines)session.go: AddedLoadShareFilesFromDisk()— copies file paths under read lock, reads content from disk outside the lockserver.go:handleSharenow usesloadCommentsForShare+LoadShareFilesFromDiskinstead of the removed functionshare_test.go: UpdatedTestHandleShare_*tests to set up real files on disk and a.crit.jsonreview fileNet: -89 lines.
Test plan
go test ./...— all passgo vet ./...— cleanmake e2e-share— all 18 share integration tests pass (includingTestShareSyncReviewLevelCommentsandTestShareSyncFullLifecycle)Closes #302