Skip to content

Review-level comments dropped when sharing from live session #297

@tomasz-tomczyk

Description

@tomasz-tomczyk

Description

buildShareFromSession in share.go:183-214 iterates s.Files and collects per-file comments, but never includes s.reviewComments. The CLI crit share path (via loadCommentsFromCritJSON) does include them.

This means review-level (non-file-scoped) comments are silently dropped when sharing from the browser's Share button during a live session.

Steps to reproduce

  1. Start a review with crit
  2. Add a review-level comment (not anchored to a file)
  3. Click Share in the browser
  4. View the shared review — review-level comment is missing

Suggested fix

After the file loop in buildShareFromSession, iterate s.reviewComments and add them as shareComment entries with Scope: "review".

Found during release audit of v0.9.1..HEAD.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions