Description
buildShareFromSession in share.go:183-214 iterates s.Files and collects per-file comments, but never includes s.reviewComments. The CLI crit share path (via loadCommentsFromCritJSON) does include them.
This means review-level (non-file-scoped) comments are silently dropped when sharing from the browser's Share button during a live session.
Steps to reproduce
- Start a review with
crit
- Add a review-level comment (not anchored to a file)
- Click Share in the browser
- View the shared review — review-level comment is missing
Suggested fix
After the file loop in buildShareFromSession, iterate s.reviewComments and add them as shareComment entries with Scope: "review".
Found during release audit of v0.9.1..HEAD.
Description
buildShareFromSessioninshare.go:183-214iteratess.Filesand collects per-file comments, but never includess.reviewComments. The CLIcrit sharepath (vialoadCommentsFromCritJSON) does include them.This means review-level (non-file-scoped) comments are silently dropped when sharing from the browser's Share button during a live session.
Steps to reproduce
critSuggested fix
After the file loop in
buildShareFromSession, iterates.reviewCommentsand add them asshareCommententries withScope: "review".Found during release audit of v0.9.1..HEAD.