fix: Fix test failures in node v14-v16 #396
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a failing socket cleanup test by destroying the request on error. This test did not fail on node v17. Closes tomas#395
355cacb to
2868f52
Compare
joeyparrish
added a commit
to joeyparrish/less.js
that referenced
this pull request
Apr 20, 2022
The issue was traced upstream to needle, and resolved in: - tomas/needle#392 - tomas/needle#394 - tomas/needle#396 - tomas/needle#398 Closes less#3693
3 tasks
iChenLei
pushed a commit
to less/less.js
that referenced
this pull request
Apr 22, 2022
The issue was traced upstream to needle, and resolved in: - tomas/needle#392 - tomas/needle#394 - tomas/needle#396 - tomas/needle#398 Closes #3693
lumburr
pushed a commit
to lumburr/less.js
that referenced
this pull request
Apr 28, 2022
The issue was traced upstream to needle, and resolved in: - tomas/needle#392 - tomas/needle#394 - tomas/needle#396 - tomas/needle#398 Closes less#3693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a failing socket cleanup test by destroying the request on
error. This test did not fail on node v17.
Closes #395