Skip to content

Conversation

@gbyl
Copy link

@gbyl gbyl commented Jun 7, 2024

@gbyl
Copy link
Author

gbyl commented Jun 7, 2024

@Eeems This package might also need to be removed. Entware now has 7-zip natively. The only difference is the hyphen in the name (Toltec: 7zip vs Entware: 7-zip):

$ opkg info 7zip
Package: 7zip
Version: 23.01-1
Status: install user installed
Section: utils
Architecture: rmall
Maintainer: Eeems <eeems@eeems.email>
Size: 971259
Filename: 7zip_23.01-1_rmall.ipk
Description: A file archiver with a high compression ratio.
$ opkg info 7-zip
Package: 7-zip
Version: 23.01-1
Depends: libc, libssp, librt, libpthread, libpthread, libstdcpp
Status: unknown ok not-installed
Section: utils
Architecture: armv7-3.2
Size: 1085100
Filename: 7-zip_23.01-1_armv7-3.2.ipk
Description: File archiver with a high compression ratio.

@Eeems
Copy link
Member

Eeems commented Jun 7, 2024

Instead of removing it, just make a meta package that contains nothing but depends on 7-zip to force anybody using the old one to update to the entware package.

@Eeems
Copy link
Member

Eeems commented Jun 7, 2024

Getting upstream updated would be good too

@Eeems Eeems added this to the 2024-W23 Merge Window milestone Jun 7, 2024
@gbyl gbyl changed the title Update 7zip to 24.06 7zip: Alias for 7-zip Jun 7, 2024
@gbyl
Copy link
Author

gbyl commented Jun 7, 2024

Could you point me to an example of a Toltec meta package? I am not sure what the bare minimum parameters are for the build to succeed

@Eeems
Copy link
Member

Eeems commented Jun 7, 2024

https://github.com/toltec-dev/toltec/blob/stable/package/toltec-deletions/package
I believe you just need a noop package method, so package() { ;; } might be enough (formatted so the linter is happy, it'll probably hate this).

@gbyl
Copy link
Author

gbyl commented Jun 7, 2024

The only thing that worked in the end was an empty echo. Should I remove or change other parameters? Maybe pkgdesc="Alias for 7-zip" or pkgdesc="Metapackage for 7-zip" to better represent the package?

@Eeems
Copy link
Member

Eeems commented Jun 7, 2024

The only thing that worked in the end was an empty echo. Should I remove or change other parameters? Maybe pkgdesc="Alias for 7-zip" or pkgdesc="Metapackage for 7-zip" to better represent the package?

true instead of echo would avoid adding an empty line to the build output.

Updating the pkgdesc would be a good idea.

@Eeems Eeems merged commit e8ea1b7 into toltec-dev:testing Jun 8, 2024
@gbyl gbyl deleted the update-7zip branch June 8, 2024 12:14
Eeems pushed a commit that referenced this pull request Jun 27, 2024
* Make 7zip a metapackage that installs 7-zip

---------

Co-authored-by: gbyl <gbyl@users.noreply.github.com>
Eeems pushed a commit that referenced this pull request Jun 29, 2024
* Make 7zip a metapackage that installs 7-zip

---------

Co-authored-by: gbyl <gbyl@users.noreply.github.com>
Eeems added a commit that referenced this pull request Sep 5, 2024
### New Packages
- `bandwich` - 0.22.2-1 (#892)
- `sysfs_preload` - 1.0.1-1 (#833)

### Updated Packages
- `7zip` - 23.01-2 (#890)
- `display`, and `rm2fb-client` - 1:0.0.33-3 (#741 #833)
- `koreader` - 2024.04-5 (#894)
- `lf` - r32-1 (#889)
- `oxide`, `oxide-extra`, `oxide-utils`, `inject_evdev`, `liboxide`, `liboxide-dev` - 2.8.4-2 (#833 #903)
- `libsentry` - 0.7.6-1 (#833 #903 )
- `bufshot` - 0.1.2-3 (#898)
- `dumbskull` - 0.0.1-4 (#898)
- `genie` - 0.1.7-2 (#898)
- `harmony` - 0.2.3-2 (#898)
- `iago` - 0.1.2-2 (#898)
- `lamp` - 0.1.1-3 (#898)
- `mines` - 0.1.4-4 (#898)
- `remux` - 0.3.0-6 (#898 #882)
- `rpncalc` - 0.0.3-4 (#898)
- `simple` - 0.2.1-2 (#898)
- `wordlet` - 0.0.2-4 (#898)
- `toltec-base` - 1.4-1 (#897)
- `toltec-bootstrap` - 0.4.5-1 (#897)
- `toltec-deletion` - 0.1-7 (#887)
- `xochitl` - 0.0.0-21 (#833)

### Packages Removed
- `bottom` - Entware now provides this package
- `ripgrep` - Entware now provides this package

### Tooling
- Update build process to use toltecmk (#789).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants