Add an explicit dependency to futures-core to console-api to fix broken builds#453
Merged
hawkw merged 1 commit intotokio-rs:mainfrom Jul 24, 2023
Merged
Add an explicit dependency to futures-core to console-api to fix broken builds#453hawkw merged 1 commit intotokio-rs:mainfrom
hawkw merged 1 commit intotokio-rs:mainfrom
Conversation
hds
approved these changes
Jul 20, 2023
Collaborator
hds
left a comment
There was a problem hiding this comment.
Thanks foe your PR!
Irrespective of why this is currently working, this is probably how it should be.
Collaborator
|
@hawkw any reason not to merge this one from your side? |
hawkw
approved these changes
Jul 24, 2023
Member
hawkw
left a comment
There was a problem hiding this comment.
This looks good to me, thanks for the fix!
hds
added a commit
that referenced
this pull request
Aug 24, 2023
Clippy was complaining about 3 new things in 1.72.0. Two new lints and one updated one. When `futures-core` was added as an explicit dependency on `console-api` in #453, it was only added to the `console-api` Cargo.toml file. It wasn't added to the Cargo.lock file shared by the workspace. Since Rust 1.72.0, Cargo is adding this dependency to Cargo.lock locally, so it makes sense to check in that change.
hawkw
pushed a commit
that referenced
this pull request
Aug 24, 2023
Clippy was complaining about 3 new things in 1.72.0. Two new lints and one updated one. When `futures-core` was added as an explicit dependency on `console-api` in #453, it was only added to the `console-api` Cargo.toml file. It wasn't added to the Cargo.lock file shared by the workspace. Since Rust 1.72.0, Cargo is adding this dependency to Cargo.lock locally, so it makes sense to check in that change.
hds
added a commit
that referenced
this pull request
Sep 21, 2023
# Changelog All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## console-api-v0.6.0 - (2023-09-21) [5a80b98](https://github.com/tokio-rs/console/commit/5a80b98c0488018015b025b895bde0c715f1601e)...[5a80b98](https://github.com/tokio-rs/console/commit/5a80b98c0488018015b025b895bde0c715f1601e) ### <a id = "console-api-v0.6.0-breaking"></a>Breaking Changes - **Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464 ([5a80b98](https://github.com/tokio-rs/console/commit/5a80b98c0488018015b025b895bde0c715f1601e))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.9. and `prost` 0.11. ### Added - [**breaking**](#console-api-v0.6.0-breaking) Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464)) ([5a80b98](5a80b98)) ### Fixed - Add explicit `futures-core` dep to fix broken builds ([#453](#453)) ([88638f9](88638f9))
hds
added a commit
that referenced
this pull request
Sep 22, 2023
# Changelog All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## console-api-v0.6.0 - (2023-09-22) [e1990f6](https://github.com/tokio-rs/console/commit/e1990f687b5d2c93e2a82973ac6c3ed91aabd56d)...[e1990f6](https://github.com/tokio-rs/console/commit/e1990f687b5d2c93e2a82973ac6c3ed91aabd56d) ### <a id = "console-api-v0.6.0-breaking"></a>Breaking Changes - **Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464 ([882318a](https://github.com/tokio-rs/console/commit/882318a006d060c763f97afa7e03a45ef9736fe6))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.9.x and `prost` 0.11.x. ### Added - [**breaking**](#console-api-v0.6.0-breaking) Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464)) ([882318a](882318a)) ### Documented - Update MSRV version docs to 1.64 ([#467](#467)) ([a7acbcc](a7acbcc)) ### Fixed - Add explicit `futures-core` dep to fix broken builds ([#453](#453)) ([88638f9](88638f9)) Signed-off-by: Hayden Stainsby <hds@caffeineconcepts.com>
hawkw
added a commit
that referenced
this pull request
Sep 29, 2023
# Changelog All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## console-api-v0.6.0 - (2023-09-29) [05cdab0](https://github.com/tokio-rs/console/commit/05cdab07a3da603697520a56f0b99b2e2042d8bd)...[f77fb77](https://github.com/tokio-rs/console/commit/f77fb770b2f5935f155df2b85ad68f035cc9eb13) ### <a id = "console-api-v0.6.0-breaking"></a>Breaking Changes - **Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464 ([882318a](https://github.com/tokio-rs/console/commit/882318a006d060c763f97afa7e03a45ef9736fe6))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.9.x and `prost` 0.11.x. ### Added - [**breaking**](#console-api-v0.6.0-breaking) Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464)) ([882318a](882318a)) ### Documented - Update MSRV version docs to 1.64 ([#467](#467)) ([a7acbcc](a7acbcc)) ### Fixed - Add explicit `futures-core` dep to fix broken builds ([#453](#453)) ([88638f9](88638f9)) Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
pushed a commit
that referenced
this pull request
Sep 29, 2023
This PR adds an explicit dependency to futures-core for `console-api` to
fix broken builds. Without this fix I get the following errors:
```
error[E0433]: failed to resolve: use of undeclared crate or module `futures_core`
--> /home/weiznich/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-api-0.5.0/src/generated/rs.tokio.console.instrument.rs:275:34
|
275 | type WatchUpdatesStream: futures_core::Stream<
| ^^^^^^^^^^^^ use of undeclared crate or module `futures_core`
error[E0433]: failed to resolve: use of undeclared crate or module `futures_core`
--> /home/weiznich/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-api-0.5.0/src/generated/rs.tokio.console.instrument.rs:289:38
|
289 | type WatchTaskDetailsStream: futures_core::Stream<
| ^^^^^^^^^^^^ use of undeclared crate or module `futures_core`
error[E0433]: failed to resolve: use of undeclared crate or module `futures_core`
--> /home/weiznich/.cargo/registry/src/index.crates.io-6f17d22bba15001f/console-api-0.5.0/src/generated/rs.tokio.console.trace.rs:212:27
|
212 | type WatchStream: futures_core::Stream<
| ^^^^^^^^^^^^ use of undeclared crate or module `futures_core`
```
The somewhat funny thing is that only happened after I've updated some
unrelated dependencies. It worked before, but after looking at the
relevant code I'm really surprised that it ever compiled without error.
hawkw
pushed a commit
that referenced
this pull request
Sep 29, 2023
Clippy was complaining about 3 new things in 1.72.0. Two new lints and one updated one. When `futures-core` was added as an explicit dependency on `console-api` in #453, it was only added to the `console-api` Cargo.toml file. It wasn't added to the Cargo.lock file shared by the workspace. Since Rust 1.72.0, Cargo is adding this dependency to Cargo.lock locally, so it makes sense to check in that change.
hawkw
added a commit
that referenced
this pull request
Sep 29, 2023
# Changelog All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## console-api-v0.6.0 - (2023-09-29) [05cdab0](https://github.com/tokio-rs/console/commit/05cdab07a3da603697520a56f0b99b2e2042d8bd)...[f77fb77](https://github.com/tokio-rs/console/commit/f77fb770b2f5935f155df2b85ad68f035cc9eb13) ### <a id = "console-api-v0.6.0-breaking"></a>Breaking Changes - **Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464 ([882318a](https://github.com/tokio-rs/console/commit/882318a006d060c763f97afa7e03a45ef9736fe6))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.9.x and `prost` 0.11.x. ### Added - [**breaking**](#console-api-v0.6.0-breaking) Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464)) ([882318a](882318a)) ### Documented - Update MSRV version docs to 1.64 ([#467](#467)) ([a7acbcc](a7acbcc)) ### Fixed - Add explicit `futures-core` dep to fix broken builds ([#453](#453)) ([88638f9](88638f9)) Signed-off-by: Eliza Weisman <eliza@buoyant.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an explicit dependency to futures-core for
console-apito fix broken builds. Without this fix I get the following errors:The somewhat funny thing is that only happened after I've updated some unrelated dependencies. It worked before, but after looking at the relevant code I'm really surprised that it ever compiled without error.