added some wait time to pse upgrade test#38
Conversation
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @TxCorpi0x)
integration-tests/upgrade/pse_staking_snapshot.go line 51 at r1 (raw file):
func (pss *pseStakingSnapshot) After(t *testing.T) { // wait for some time for scores to be accumulated time.Sleep(2 * time.Second)
slightly better version here would be to wait for a few blocks
I think we have this helper func
ysv
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, and @TxCorpi0x)
integration-tests/upgrade/pse_staking_snapshot.go line 51 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
slightly better version here would be to wait for a few blocks
I think we have this helper func
@miladz68 feel free to resolve and merge
miladz68
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @TxCorpi0x, and @ysv)
integration-tests/upgrade/pse_staking_snapshot.go line 51 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
@miladz68 feel free to resolve and merge
Done.
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @TxCorpi0x)
masihyeganeh
left a comment
There was a problem hiding this comment.
@masihyeganeh reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
masihyeganeh
left a comment
There was a problem hiding this comment.
@masihyeganeh reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
* added some wait time to pse upgrade test * fix a comment * changed the wait logic * fix linter * Merge branch 'master' into milad/add-wait-pse-upgrade-test
Description
Reviewers checklist:
Authors checklist
This change is