@ysv reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @masihyeganeh and @miladz68)

integration-tests/modules/pse_test.go line 91 at r1 (raw file):

	// Score should be non-negative
	requireT.False(finalResp.Score.IsNegative(), "score should not be negative")

what about 0 ?
zero is not negative so it might be successful here

integration-tests/modules/pse_test.go line 291 at r1 (raw file):

	// Score should still be non-negative and should have increased
	requireT.False(scoreAfterUndelegate.Score.IsNegative(), "score should not be negative")
	requireT.True(scoreAfterUndelegate.Score.GT(scoreAfterDelegate.Score), "score should increase after more blocks")

I think we should also verify that after undelegation it stops increasing

integration-tests/modules/pse_test.go line 342 at r1 (raw file):

		// Score should be non-negative
		requireT.False(scoreResp.Score.IsNegative(), "validator score should not be negative")

do we really have score for validators ? is it correct ?

integration-tests/modules/pse_test.go line 375 at r1 (raw file):

		// Verify account name is valid
		requireT.Contains(allAccounts, balance.ClearingAccount, "clearing account should be valid")

nit: maybe we should also verify that clearingAcc balance is > 0
Or it is not true on znet ?

integration-tests/modules/pse_test.go line 390 at r1 (raw file):

// TestPSEQueryScheduledDistributions tests the ScheduledDistributions query endpoint.
func TestPSEQueryScheduledDistributions(t *testing.T) {

do we have ScheduledDistributions on znet ?
if no distributions exist should we even test this ?
@miladz68 WDYT ?

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @masihyeganeh, @miladz68, and @ysv)

integration-tests/modules/pse_test.go line 91 at r1 (raw file):

Done

integration-tests/modules/pse_test.go line 291 at r1 (raw file):

Done

integration-tests/modules/pse_test.go line 342 at r1 (raw file):

The names were inconsistent, i replaced it with alternative test that covers no delegations, the intent in this test was to track self delegation which is not needed anymore

integration-tests/modules/pse_test.go line 375 at r1 (raw file):

Clearing accounts have balances (with the other merged PR for znet mint). Modified for clarity

integration-tests/modules/pse_test.go line 390 at r1 (raw file):

The test removed

@ysv reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @miladz68)

@miladz68 reviewed 2 of 3 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)

integration-tests/modules/pse_test.go line 390 at r1 (raw file):

@TxCorpi0x is the test removed now ?

x/pse/client/cli/query_test.go line 42 at r3 (raw file):

}

func TestQueryScore_WithValidatorAddress(t *testing.T) {

how is this test different than TestQueryScore_NoScore

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, and @ysv)

integration-tests/modules/pse_test.go line 390 at r1 (raw file):

There was conflicts in local branch after multiple merges to master, fixed and removed the test

x/pse/client/cli/query_test.go line 42 at r3 (raw file):

There was conflicts in local branch after multiple merges to master, fixed and removed the test

@miladz68 reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@ysv reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)