Skip to content

Chore(deps): bump cosmos/iavl v1.2.4 to v1.2.8#118

Merged
metalarm10 merged 3 commits into
masterfrom
john/update-iavl-deps
Apr 13, 2026
Merged

Chore(deps): bump cosmos/iavl v1.2.4 to v1.2.8#118
metalarm10 merged 3 commits into
masterfrom
john/update-iavl-deps

Conversation

@metalarm10

@metalarm10 metalarm10 commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Description

Bumps github.com/cosmos/iavl from v1.2.4 to v1.2.8 (latest of the v1.2.x backport line).

Why?
Mainnet full nodes show runaway application.db growth despite aggressive pruning config. The symptom matches iavl#1063: nodeDB.deleteVersion treats ErrVersionDoesNotExist as fatal and silently halts pruning, dangling roots accumulate, no error logged.
Same bug observed by Osmosis operators (see #1065 description).

Fixes pulled in (v1.2.4 → v1.2.8)

#1065 (backport of #1063) — primary fix: continue pruning when version not found
#1067 — get-latest-version after legacy pruning fails
#983 — wait for previous batch on importer.Commit
#1142 — fast-node cache vs db commit race
#1029 — rootkey cache perf (~27% faster pruning)
Refs: v1.2.4...v1.2.8 compare · CHANGELOG@v1.2.8

Testing

Tested on mainnet node "Corium", confirmed that iavl-v1.2.8 version is backwards compatbile with existing mainnet version iavl-1.2.4.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@metalarm10 metalarm10 marked this pull request as ready for review April 8, 2026 14:04
@metalarm10 metalarm10 requested a review from a team as a code owner April 8, 2026 14:04
@metalarm10 metalarm10 requested review from TxCorpi0x, masihyeganeh, miladz68 and ysv and removed request for a team April 8, 2026 14:04

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x reviewed 7 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on masihyeganeh, miladz68, and ysv).

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 7 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on masihyeganeh and miladz68).

@metalarm10 metalarm10 merged commit 7406403 into master Apr 13, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants