fix: batch write race on commit by corverroos · Pull Request #983 · cosmos/iavl

corverroos · 2024-08-19T10:25:51Z

Wait for previous batch before writing batch on importer.Commit

coderabbitai · 2024-08-19T10:26:01Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

corverroos · 2024-08-19T12:35:42Z

For more context, see this issue on omni that resulted in this PR.

corverroos · 2024-08-19T12:45:45Z

+	// Wait for previous batch.
+	var err error
+	if i.inflightCommit != nil {
+		err = <-i.inflightCommit


maybe using a sync.Mutex around batch.Write(Sync) and batch.Commit would be easier to reason about?

cool-develope

lgtm!

kocubinski

nice catch, lgtm

cool-develope · 2024-08-27T14:32:45Z

@Mergifyio backport master

mergify · 2024-08-27T14:32:51Z

backport master

🛑 Command `backport master` cancelled because of a new `backport` command with different arguments

corverroos · 2024-09-19T12:39:14Z

Hi all, is there anything more I need to do from my side?

tac0turtle · 2024-09-23T11:13:02Z

@Mergifyio backport master

(cherry picked from commit fe80f0a)

mergify · 2024-09-23T11:13:23Z

backport master

✅ Backports have been created

Details

#992 fix: batch write race on commit (backport #983) has been created for branch master

Co-authored-by: corver <corver.roos@gmail.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: corver <corver.roos@gmail.com>

v1.2.5 contains the backport of cosmos/iavl#983 which fixes a race in Importer.Commit: LoadVersion could run before the previous async batch finished writing, leaving the imported IAVL tree incomplete. On statesync joiners this surfaced as FinalizeBlock returning "validator does not exist" on the first replayed block.

## Summary Bumps `github.com/cosmos/iavl` from `v1.2.2` to `v1.2.5`. `v1.2.5` backports [cosmos/iavl#983](cosmos/iavl#983), which fixes a race in `Importer.Commit`: `LoadVersion` could run before the previous async batch write had finished, leaving the imported IAVL tree incomplete. On state-synced nodes this surfaced as `FinalizeBlock` returning `"validator does not exist"` on the first replayed block. issue: #829

fix: batch write race on commit

1246525

corverroos requested a review from a team August 19, 2024 10:25

tac0turtle assigned cool-develope Aug 19, 2024

corverroos mentioned this pull request Aug 19, 2024

Panic while joining a network: validator does not exist omni-network/omni#1524

Closed

corverroos commented Aug 19, 2024

View reviewed changes

tac0turtle assigned kocubinski Aug 27, 2024

cool-develope approved these changes Aug 27, 2024

View reviewed changes

kocubinski approved these changes Aug 27, 2024

View reviewed changes

tac0turtle merged commit fe80f0a into cosmos:release/v1.1.x Sep 23, 2024

mergify Bot pushed a commit that referenced this pull request Sep 23, 2024

fix: batch write race on commit (#983)

05fd70e

(cherry picked from commit fe80f0a)

mergify Bot mentioned this pull request Sep 23, 2024

fix: batch write race on commit (backport #983) #992

Merged

tac0turtle pushed a commit that referenced this pull request Sep 23, 2024

fix: batch write race on commit (backport #983) (#992)

34895bf

Co-authored-by: corver <corver.roos@gmail.com>

beer-1 pushed a commit to initia-labs/iavl that referenced this pull request Mar 6, 2025

fix: batch write race on commit (backport cosmos#983) (cosmos#992)

7e52e75

Co-authored-by: corver <corver.roos@gmail.com>

aljo242 pushed a commit that referenced this pull request Mar 6, 2025

fix: batch write race on commit (backport #983) (#992) (#1057)

6cfb3da

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: corver <corver.roos@gmail.com>

metalarm10 mentioned this pull request Apr 7, 2026

Chore(deps): bump cosmos/iavl v1.2.4 to v1.2.8 tokenize-x/tx-chain#118

Merged

6 tasks

0xHansLee mentioned this pull request May 21, 2026

fix(deps): bump cosmos iavl from v1.2.2 to v1.2.5 piplabs/story#832

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: batch write race on commit#983

fix: batch write race on commit#983
tac0turtle merged 1 commit into
cosmos:release/v1.1.xfrom
omni-network:corver/fixbatchimportrace

corverroos commented Aug 19, 2024

Uh oh!

coderabbitai Bot commented Aug 19, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

corverroos commented Aug 19, 2024

Uh oh!

corverroos Aug 19, 2024 •

edited

Loading

Uh oh!

cool-develope left a comment

Uh oh!

kocubinski left a comment

Uh oh!

cool-develope commented Aug 27, 2024

Uh oh!

mergify Bot commented Aug 27, 2024 •

edited

Loading

Uh oh!

corverroos commented Sep 19, 2024 •

edited

Loading

Uh oh!

tac0turtle commented Sep 23, 2024

Uh oh!

mergify Bot commented Sep 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Conversation

corverroos commented Aug 19, 2024

Uh oh!

coderabbitai Bot commented Aug 19, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

corverroos commented Aug 19, 2024

Uh oh!

corverroos Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cool-develope left a comment

Choose a reason for hiding this comment

Uh oh!

kocubinski left a comment

Choose a reason for hiding this comment

Uh oh!

cool-develope commented Aug 27, 2024

Uh oh!

mergify Bot commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛑 Command backport master cancelled because of a new backport command with different arguments

Uh oh!

corverroos commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tac0turtle commented Sep 23, 2024

Uh oh!

mergify Bot commented Sep 23, 2024

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)

corverroos Aug 19, 2024 •

edited

Loading

mergify Bot commented Aug 27, 2024 •

edited

Loading

🛑 Command `backport master` cancelled because of a new `backport` command with different arguments

corverroos commented Sep 19, 2024 •

edited

Loading