Fix various ShellCheck violations#57
Merged
kvendingoldo merged 1 commit intotofuutils:mainfrom Feb 16, 2024
Merged
Conversation
Signed-off-by: Edwin Kofler <edwin@kofler.dev>
d46003e to
5f89a32
Compare
| local pwd="$(pwd)"; | ||
| log 'debug' "Deleting ${pwd}/version"; | ||
|
|
||
| log 'debug' "Deleting ${PWD}/version"; |
Contributor
There was a problem hiding this comment.
where PWD is declared?
Contributor
Author
There was a problem hiding this comment.
@kvendingoldo PWD is declared/set by the cd builtin and by the shell on initialization. It's in POSIX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the spirit of tfutils/tfenv#426 and tfutils/tfenv#424, this fixes various ShellCheck violations. They include:
&&instead of-a[ -nmust be used with a quoted argument-nover! -zgrep -q