Update Cobra sub commands to use RunE#254
Merged
dvaumoron merged 1 commit intotofuutils:mainfrom Sep 28, 2024
Merged
Conversation
Update all the sub command to make use of the RunE function call. This will allow any error event in the run command to cause tenv to exit with a non zero value. This is useful to detect install and update failures in scripts. Signed-off-by: Nicholas Thompson <github@hoekwil.com>
Collaborator
|
Agree, it can be really useful. |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Oct 11, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [tofuutils/tenv](https://github.com/tofuutils/tenv) | minor | `v3.1.0` -> `v3.2.4` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>tofuutils/tenv (tofuutils/tenv)</summary> ### [`v3.2.4`](https://github.com/tofuutils/tenv/releases/tag/v3.2.4) [Compare Source](tofuutils/tenv@v3.2.3...v3.2.4) #### What's Changed - docs: add Oh My Zsh completion by [@​samuel-phan](https://github.com/samuel-phan) in tofuutils/tenv#258 - Fix : proxy missing env by [@​dvaumoron](https://github.com/dvaumoron) in tofuutils/tenv#260 #### New Contributors - [@​samuel-phan](https://github.com/samuel-phan) made their first contribution in tofuutils/tenv#258 **Full Changelog**: tofuutils/tenv@v3.2.3...v3.2.4 ### [`v3.2.3`](https://github.com/tofuutils/tenv/releases/tag/v3.2.3) [Compare Source](tofuutils/tenv@v3.2.2...v3.2.3) #### What's Changed - go: bump github.com/charmbracelet/bubbletea from 1.1.0 to 1.1.1 by [@​dependabot](https://github.com/dependabot) in tofuutils/tenv#251 - Update Cobra sub commands to use RunE by [@​ncthompson](https://github.com/ncthompson) in tofuutils/tenv#254 - Avoid duplicate error message display by [@​dvaumoron](https://github.com/dvaumoron) in tofuutils/tenv#256 #### New Contributors - [@​ncthompson](https://github.com/ncthompson) made their first contribution in tofuutils/tenv#254 **Full Changelog**: tofuutils/tenv@v3.2.2...v3.2.3 ### [`v3.2.2`](https://github.com/tofuutils/tenv/releases/tag/v3.2.2) [Compare Source](tofuutils/tenv@v3.2.1...v3.2.2) #### What's Changed - Fix : read iac files from WorkPath (chdir proxy flag) by [@​dvaumoron](https://github.com/dvaumoron) in tofuutils/tenv#250 **Full Changelog**: tofuutils/tenv@v3.2.1...v3.2.2 ### [`v3.2.1`](https://github.com/tofuutils/tenv/releases/tag/v3.2.1) [Compare Source](tofuutils/tenv@v3.1.0...v3.2.1) #### What's Changed - fix : skip all cosign tests by [@​dvaumoron](https://github.com/dvaumoron) in tofuutils/tenv#248 **Full Changelog**: tofuutils/tenv@v3.2.0...v3.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a use case where we pre-install terraform and terragrunt versions for pipeline usage, to ensure we don't get rate limited. The problem is, that if the installation fails, it does not fail the build process. This is because tenv always exists with status
0.You can simulate this with
This change makes use of Cobra's
RunEcommand instead of just theRuncommand for all sub command calls. This will allow any error event in the run command to cause tenv to exit with a non zero value. This is useful to detect install and update failures in scripts.Sample output with the change implemented: