Support specified config directory and XDG Base Dirs Spec (redux) #511
Conversation
* Add tmux versions 2.2 and 2.3 TravisCI * Mov gem deps from Gemfile to tmuxinator.gemspec Close tmuxinator#459. Close tmuxinator#465.
|
Seriously, how long does it take for Code Climate to run? It's been 2 days now. I see: @ethagnawl do you see the same? |
|
@ethagnawl @seanmalloy Any comments? Can this be merged now? (It's been 2.5 months.) It seems that codeclimate has indeed passed its checks when I click through (but the status isn't updated on this page). |
|
Agree w/ @HaleTom that clicking through to CC shows completed/passed; IDK why it isn't updated here. I say LGTM. @ethagnawl @Soliah any objections? |
|
@HaleTom @adamstrickland No objections from me. 🤞 |
|
So, I pulled these changes into my repo to find out what was going on with CC, and found that CC is (now?) using rubocop 0.46.0, which was borking my ability to run it (IDK if it's related to the weird badge situation in this branch). I have fixed the issues in #522. Will merge that in and then this PR. |
|
Hello, |
|
Tmuxinator doesn't set any new environment variables and there's no way to interrogate the running process, but it does respect |
Allow setting config directory and honour XDG Base Dirs Spec
Resolve Issue #462 - "Tmuxinator config files in a different location"
Resolve Issue #360 - "XDG base directory support"
Mentioned in Issue #427 - "Introduce Analytics Module"
Allow
$TMUXINATOR_CONFIGto specify a configuration directory, whichwill be created (including its parent directories) if it doesn't exist. This
directory takes preference over honouring the XDG specification (below). If
specified, this will be the only configuration location used.
Honour the XDG Base Directories Specification
with regards to user specific configuration files: Look for
tmuxinatorconfiguration files under
$XDG_CONFIG_HOME/tmuxinator.For existing setups with no
$XDG_CONFIG_HOMEdirectory, continue tocreate new projects in
~/.tmuxinatorfor backwards compatibility.If
$XDG_CONFIG_HOME/tmuxinatorexists, create new projects there.If neither
~/.tmuxinatornor$XDG_CONFIG_HOME/tmuxinatorexist, use$XDG_CONFIG_HOME/tmuxinatorfor new projects. Create this directory(including its parents) if it does not exist.
When loading a project, search
$XDG_CONFIG_HOME/tmuxinatorbefore~/.tmuxinator. Document in comments and tests the existing behaviourof returning only the first project file found in a recursive search of
a configuration directory.
Add
Config#directories: an array of the configuration director{y,ies}which exist. Update commands
implodeandlistto operate upon thisarray.
Add
aliases for the 3 renamed methods below for backwardcompatibility:
Rename
Config#root->Config#directoryThis directory is the only one used when creating new project files, and
may be either
$TMUXINATOR_CONFIG,$XDG_CONFIG_HOME/tmuxinatoror~/.tmuxinator.Implementing XDG Base Dirs support with backwards compatibility means
that two directories may contain project files, making the
rootnomenclature misleading as it implies a single directory.
Rename
Config#project_in_root->Config#global_projectSee comment on
rootterminology above.global_projectis alsoshorter and corresponds to the naming of
default_projectRename
Config#project_in_local->Config#local_projectFit with the naming of both
global_projectanddefault_projectSort gem dependencies into alphabetical order
Related pull requests:
Support specified config directory and XDG Base Dirs Spec #479 "Support specified config directory and XDG Base Dirs Spec" -
initial PR
Revert "Support specified config directory and XDG Base Dirs Spec" #505 "Revert "Support specified config directory and XDG Base Dirs
Spec" - Did not run correctly in CI environment
Sort output of Dir.glob for consistency #506 "Sort output of Dir.glob for consistency" - fix for CI
environment
Attempt at salvaging PR #479 #507 "Attempt at salvaging PR Support specified config directory and XDG Base Dirs Spec #479" - Work around Sort output of Dir.glob for consistency #506 being ignored
due to some of its commits being included in the reverted Revert "Support specified config directory and XDG Base Dirs Spec" #505