I'm having a minor problem with the 2nd test that has stumped me.

The test fails with

--- FAIL: TestDockerignoreWithMultiplePaths (0.01 seconds)
    utils.go:123: build failed to complete: Uploading context  2.56 kB
        Uploading context 
        2014/06/01 08:58:45 Error: Can't build a directory with no Dockerfile
         exit status 1

I cannot work out why its complaining that it can't see the Dockerfile in that dir.

updated, my sh skills need work.

Added another test, 2/3 are still failing though for reasons I can't figure out.

now rebased on dotcloud/docker

I managed to screw this up with the rebase, going to close and do it again cleanly

Cool, no problem

This time its the correct commits, without any mistakes in the rebase.

Still 2 problems.

TestDockerignoreCanIgnoreDockerfile fails, but looking closer at the interaction of the builder, it actually builds using the tar that it receives from archive? That would mean dockerignoring the actual Dockerfile is never going to work.

TestDockerignoreWithMultiplePaths fails too, but this one I can't understand. The dockerignore doesn't mention the Dockerfile at all, but the builder still complains that it didn't get a Dockerfile in the archive.

@wyaeld Yeah, ignoring Dockerfile doesn't make sense, I think we should put check about it in api.
I don't see also what the problem with multiple paths, but if you have time you can put some debug messages to archive and see what's really going on. Feel free ask me for help.

Ok, so the TestDockerignoreCanIgnoreDockerfile isn't valid, and needs to be removed and the behaviour documented, plus probably a check as you say.

TestDockerignoreWithMultiplePaths still a problem. I haven't had much time yet, will have some in a couple of days, but any assistance appreciated