Updates for Qt5#50
Closed
zquestz wants to merge 3 commits into
Closed
Conversation
zquestz
commented
Oct 4, 2024
zquestz
commented
Oct 4, 2024
zquestz
commented
Oct 4, 2024
zquestz
commented
Oct 4, 2024
zquestz
commented
Oct 4, 2024
zquestz
commented
Oct 4, 2024
Owner
|
Thank you for the PR. But this would break Qt 4 compatibility, which we specifically use to maintain builds for older macs. QStandardPaths for example did not exist until Qt 5. |
Contributor
Author
|
Did you want to maintain a Qt5 branch? |
Contributor
Author
|
Also, can you look at the last two comments, want to make sure those are right. =) |
Owner
We actually downgraded from Qt 5 to 4 to make it compatible on older machines. As long as Qt 4 works on modern ones I see no point really. |
Contributor
Author
|
Gotcha, then I will just maintain my patch for the AUR! |
Owner
|
Thank you. I will implement some of the tweaks and fixes you did. Closing this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes all essential deprecation warnings and a bunch of small warning nits.
Code compiles and works well using Qt5.
The only unresolved warnings are unused variables and params. I can live with those.