Add public reset method to enable multiple calls to parse.#499
Closed
lukeasrodgers wants to merge 1 commit intotj:masterfrom
Closed
Add public reset method to enable multiple calls to parse.#499lukeasrodgers wants to merge 1 commit intotj:masterfrom
reset method to enable multiple calls to parse.#499lukeasrodgers wants to merge 1 commit intotj:masterfrom
Conversation
This makes it easier to unit test code that runs commander.
|
This would definitely be helpful |
abetomo
approved these changes
Jun 28, 2017
Collaborator
|
Unnecessary, a new command can be instantiated by using |
Collaborator
|
Commander itself (main function) is an instance of Commander object. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to unit test code that runs commander.
Addresses #438
I don't have tons of experience with commander.js so this approach may not work for all cases.