Closed
Conversation
This was referenced Aug 13, 2023
This reverts commit 5c5c972. Reverted for the cae a different suggestion with a fix for that script is accepted.
This was referenced Aug 15, 2023
Fixes type errors revealed after enabling useUnknownInCatchVariables
Collaborator
|
This is a collection of various PRs, and fixes issues for checks that are not enabled in the existing codebase. The type checks in #1969 generate no failures. Too messy to review in detail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all type errors revealed by the TypeScript check fixed in #1960.
Builds on the fix from #1960, excluding the questionable script rename 273a35d.
Diff only for the changes introduced by this PR:
aweebit/commander.js@5c5c972...fix/type-errors
Includes fixes merged from #1963 #1965 #1966.
ChangeLog
Fixed
undefinedand arbitrary custom source strings are allowed now).executableDir()Peer PRs
Changes are to be merged into…