Conversation
typescript-checkJS scripttypescript-checkJS script. Store config in jsconfig.json so that it is picked up by VS Code
27f4f71 to
1d8e95d
Compare
typescript-checkJS script. Store config in jsconfig.json so that it is picked up by VS Codetypescript-checkJS script. Store config for the script in jsconfig.json so that it is picked up by VS Code
fd12ba3 to
1322cac
Compare
typescript-checkJS script. Store config for the script in jsconfig.json so that it is picked up by VS Codetypescript-checkJS script
1322cac to
f78ddd6
Compare
For better consistency with the TSConfig option name. The script had been broken for a long time, so it is safe to assume nobody relies on the old name in custom scripts.
f78ddd6 to
273a35d
Compare
|
Enough rebases, should be good to go now. |
|
The script runs fine on Mac, I use it as part of |
Checked it on Debian and the result was the same as what you get. However, it isn't correct. There are currently a lot of type errors in the code and we are supposed to see them, instead we see nothing. |
|
Even when running the command for one individual file that has type errors (a lot of them) and with the exact option names from TypeScript's documentation, it still doesn't output anything: So the command has been misleading the entire time even if it has been in use, so renaming it might not be a good idea. |
|
There are (at least!) 3 different things going on:
The command-line help gives one clue, specifying the files apparently uses the default compiler options: I haven't yet managed to get VSCode to do the gentler type checking that |
|
Managed to get looser checks matching run-script in VSCode with both of these in |
|
Closing in favor of #1969. |
Problem
Currently,
npm run typescript-checkJSresults inon Windows (even when run from Git Bash), and in normal termination with no output even when there are type errors in the files on Linux and macOS.
Solution
Fix the script command.
The configuration for the JS check has been moved to a dedicated config file.
The script has been renamed to
typescript-checkJsfor better consistency with the TSConfig option name. (The script has been broken for a long time without someone noticing, so it is safe to assume it is not used in any contributors' custom scripts, and so the rename won't break anything.)Peer PRs
…building upon this one
typescript-checkJSscript. Store config for the script injsconfig.jsonso that it is picked up by VS Code #1962