Extend .argument() to add default value and custom parse for command-argument#1508
Merged
shadowspawn merged 16 commits intotj:release/8.xfrom May 3, 2021
Merged
Conversation
abetomo
reviewed
May 2, 2021
| */ | ||
|
|
||
| argumentDescription(argument) { | ||
| const extraInfo = []; |
Collaborator
There was a problem hiding this comment.
extraInfo appears to have only 0 or 1 elements.
Does it need to be an array?
Collaborator
Author
There was a problem hiding this comment.
Fair question. No, does not need to be an array currently. However, I left in the array as planning to add choices, like optionDescription which I copied the code from.
Collaborator
Author
|
Thanks @abetomo |
This was referenced May 22, 2021
kevinoid
added a commit
to kevinoid/noderegression
that referenced
this pull request
Jan 31, 2022
InvalidOptionArgumentError was renamed to InvalidArgumentError in tj/commander.js#1508 for commander@8.0.0. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid
added a commit
to kevinoid/hub-ci-status
that referenced
this pull request
Jan 31, 2022
InvalidOptionArgumentError was renamed to InvalidArgumentError in tj/commander.js#1508 for commander@8.0.0. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid
added a commit
to kevinoid/swagger-spec-validator
that referenced
this pull request
Jan 31, 2022
InvalidOptionArgumentError was renamed to InvalidArgumentError in tj/commander.js#1508 for commander@8.0.0. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid
added a commit
to kevinoid/fetch-procore-api-docs
that referenced
this pull request
Jan 31, 2022
InvalidOptionArgumentError was renamed to InvalidArgumentError in tj/commander.js#1508 for commander@8.0.0. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid
added a commit
to kevinoid/node-project-template
that referenced
this pull request
Jan 31, 2022
InvalidOptionArgumentError was renamed to InvalidArgumentError in tj/commander.js#1508 for commander@8.0.0. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid
added a commit
to kevinoid/procore-docs-to-openapi
that referenced
this pull request
May 6, 2022
InvalidOptionArgumentError was renamed to InvalidArgumentError in tj/commander.js#1508 for commander@8.0.0. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
Follow through with the idea that
.argument()follow same pattern as.option(), with support for default value (for optional arguments) and custom command-argument parsing.Solution
Support for default value (for optional arguments) and custom command-argument parsing.
Implementation notes:
program.argsChangeLog
InvalidOptionArgumentError(replaced byInvalidArgumentError)CommanderErrorcodecommander.invalidOptionArgumentrenamedcommander.invalidArgument