Feature/clean up created containers#139
Merged
mcred merged 5 commits intotitan-data:masterfrom Dec 17, 2019
Merged
Conversation
added 3 commits
December 16, 2019 21:11
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
eschrock
reviewed
Dec 17, 2019
Contributor
eschrock
left a comment
There was a problem hiding this comment.
Can you fix the other variants to be consistent while you're here?
- containerIsRunning()
- containerIsStopped()
- containerExists()
Signed-off-by: Derek Smart <derek.smart@delphix.com>
eschrock
approved these changes
Dec 17, 2019
mcred
added a commit
to mcred/titan
that referenced
this pull request
Dec 17, 2019
Feature/clean up created containers (titan-data#139)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove container on exact name match.
Testing
E2E tests added and ran locally.