initial kubernetes context stub#104
Merged
mcred merged 2 commits intotitan-data:masterfrom Nov 18, 2019
Merged
Conversation
mcred
approved these changes
Nov 18, 2019
mcred
pushed a commit
to mcred/titan
that referenced
this pull request
Nov 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This adds a stub of a context for invoking titan-server in kubernetes context. This is activated by setting
TITAN_CONTEXT=kubernetesin the environment. This runs an entirely parallel installation, with the identity "titan-k8s" instead of "titan", and running on port 5002 instead of 5002. This allows both contexts to co-exist during this alpha period (prior to having first-class context support). For now, we've just implemented the install/uninstall endpoints and list repositories.I've held off writing extensive endtoend tests because there's still a lot of ambiguity around how this new context will evolve and how we'll automate access to shared k8s environments, etc.
Testing
Ran unit tests, as well as getting started end2end tests. Manual testing includes:
Ability to run side-by-side
Functioning kubernetes