Skip to content

Add Brazilian Portuguese to Google dictionary and fix Portugal Portug…#951

Merged
tisfeng merged 2 commits intotisfeng:mainfrom
joaovitoras:patch-1
Aug 24, 2025
Merged

Add Brazilian Portuguese to Google dictionary and fix Portugal Portug…#951
tisfeng merged 2 commits intotisfeng:mainfrom
joaovitoras:patch-1

Conversation

@joaovitoras
Copy link
Copy Markdown
Contributor

@joaovitoras joaovitoras commented Aug 23, 2025

This pull request updates the language code mappings for Portuguese in the Google Translate service. Specifically, it distinguishes between Brazilian Portuguese and European Portuguese by assigning them their respective language codes.

Language code mapping updates:

  • In EZGoogleTranslate.m, mapped EZLanguageBrazilianPortuguese to pt-BR and EZLanguagePortuguese to pt-PT to differentiate between Brazilian and Portugal Portuguese.

Close #945

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello joaovitoras, Thank you for your first PR contribution 🎉 joaovitoras

Updates the language code for Brazilian Portuguese from "pt" to "pt-BR" in the Google Translate service mapping.

This change ensures that translation requests for Brazilian Portuguese are sent with the correct and specific regional code, distinguishing it from European Portuguese (`pt-PT`) and resolving potential translation inaccuracies.
Copy link
Copy Markdown
Owner

@tisfeng tisfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Easydict/objc/Service/Google/EZGoogleTranslate.m
@tisfeng tisfeng merged commit 4585338 into tisfeng:main Aug 24, 2025
4 checks passed
Keldos-Li pushed a commit to Keldos-Li/Easydict that referenced this pull request Sep 3, 2025
tisfeng#951)

* Add Brazilian Portuguese to Google dictionary and fix Portugal Portuguese

* fix(google-translate): correct language code for Brazilian Portuguese

Updates the language code for Brazilian Portuguese from "pt" to "pt-BR" in the Google Translate service mapping.

This change ensures that translation requests for Brazilian Portuguese are sent with the correct and specific regional code, distinguishing it from European Portuguese (`pt-PT`) and resolving potential translation inaccuracies.

---------

Co-authored-by: tisfeng <tisfeng@gmail.com>
tisfeng added a commit that referenced this pull request Sep 6, 2025
#951)

* Add Brazilian Portuguese to Google dictionary and fix Portugal Portuguese

* fix(google-translate): correct language code for Brazilian Portuguese

Updates the language code for Brazilian Portuguese from "pt" to "pt-BR" in the Google Translate service mapping.

This change ensures that translation requests for Brazilian Portuguese are sent with the correct and specific regional code, distinguishing it from European Portuguese (`pt-PT`) and resolving potential translation inaccuracies.

---------

Co-authored-by: tisfeng <tisfeng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Bug Report: 💥 Failed, Unsupported language: Brazilian-Portuguese

2 participants