Fixed roman numeral detection with copy-paste from Word.#6689
Merged
ltrouton merged 1 commit intotinymce:TINY-7368from May 4, 2021
Merged
Fixed roman numeral detection with copy-paste from Word.#6689ltrouton merged 1 commit intotinymce:TINY-7368from
ltrouton merged 1 commit intotinymce:TINY-7368from
Conversation
Fixes tinymce#6620 Previously roman numerals with more than two characters caused the list to split into two. E.g. the list below would split to ol & ul at third item: i. First ii. Second iii. Third The included test case covers numerals from I to X.
2 tasks
metricjs
approved these changes
Apr 9, 2021
JamesToohey
approved these changes
Apr 12, 2021
Contributor
JamesToohey
left a comment
There was a problem hiding this comment.
Looks good, thanks @aautio!
Can we please add a changelog entry in the Fixed section for this?
modules/tinymce/CHANGELOG.md
Something like
Fixed a bug where lists pasted from Word with Roman numeral markers were not displayed correctly #GH-6620
lnewson
approved these changes
Apr 29, 2021
6 tasks
ltrouton
added a commit
that referenced
this pull request
May 4, 2021
…6784) * Fixed roman numeral detection with copy-paste from Word. (#6689) Fixes #6620 Previously roman numerals with more than two characters caused the list to split into two. E.g. the list below would split to ol & ul at third item: i. First ii. Second iii. Third The included test case covers numerals from I to X. * TINY-7368: Add changelog entry Co-authored-by: Ari Autio <ari.autio@iki.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces #6621 as agreed with @JamesToohey.
Fixes #6620
Previously roman numerals with more than two characters
caused the list to split into two. E.g. the list below would split
to ol & ul at third item:
The included test case covers numerals from I to X.
Pre-checks:
Review:
GitHub issues (if applicable):