Add missing js files in python package data for viz #10624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Could repro, thanks for the fix. I'll investigate while the use as external package CI did not catch this earlier. |
Merged
utkarshgill
pushed a commit
to utkarshgill/tinygrad
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed tinygrad with uv to try it out
Then wrote a simple tinygrad program and run it with the VIZ web tool:
But the web UI is not working. I looked into Chrome console and noticed that the
index.jscannot be found:I looked at the package installed by uv at my virtualenv folder, and realized that the js files in the
viz/jsare not there. Checked with thesetup.pyfile, it turns out that the js folder is missing there. This PR adds the missing path.I just tried it with
python setup.py sdist:Then run
And can confirm now the missing js files are included