-
Notifications
You must be signed in to change notification settings - Fork 1k
machine/rp2350: add flash support for rp2350 #4803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ok, I had a chance to test the console functions in https://github.com/tinygo-org/tinyfs/blob/release/examples/console/littlefs/machine/main.go and it seems to be working as far as I can tell, but I've not used tinyfs before |
ec9f977 to
432b01d
Compare
|
I'm not the right reviewer for the details of the flash interface. Perhaps @deadprogram who authored the other implementation. |
|
Sounds good. It's mostly just copy/paste from pico-sdk with the RISC-V and RP2040-specific macro branches trimmed out and I grouped everything by source file with a header comment so it should hopefully be relatively straightforward to cross-reference. The only real changes I made were to mimic the conversion of |
|
Thank you for working on this @mikesmitty and to @eliasnaur for review. I tested on real hardware, working exactly as expected. Now squash/merging. Thanks again! |
|
Thanks! |
* machine/rp2350: add flash support for rp2350 * combine duplicate files * clean things up and group by source file * add stubbed out xip cache clean func if needed in the future * update flash_enable_xip_via_boot2 * remove unused macros and fix inconsistent formatting * make flash size configurable like rp2040 * add missing flash size configs * retain big Go CGo compatibility per #4103 * clarify CS0_SIZE source and remove single-use typedef
Hi all, this still needs a bit of cleanup and I haven't had the chance to properly test it on hardware, but it builds cleanly. Figured I'd push it up to see if any big changes need to happen before I give it a final polish.
Fixes #4799