Skip to content

some minor code cleanups#918

Merged
aviatesk merged 2 commits intomasterfrom
avi/minor-cleanups
May 19, 2025
Merged

some minor code cleanups#918
aviatesk merged 2 commits intomasterfrom
avi/minor-cleanups

Conversation

@aviatesk
Copy link
Copy Markdown
Collaborator

No description provided.

@aviatesk aviatesk merged commit 830de99 into master May 19, 2025
9 of 13 checks passed
@aviatesk aviatesk deleted the avi/minor-cleanups branch May 19, 2025 13:41
timholy added a commit that referenced this pull request Jul 25, 2025
timholy added a commit that referenced this pull request Jul 26, 2025
aviatesk pushed a commit that referenced this pull request Oct 18, 2025
aviatesk pushed a commit that referenced this pull request Oct 22, 2025
aviatesk pushed a commit that referenced this pull request Dec 5, 2025
aviatesk pushed a commit that referenced this pull request Dec 23, 2025
aviatesk pushed a commit that referenced this pull request Dec 24, 2025
aviatesk pushed a commit that referenced this pull request Dec 24, 2025
aviatesk pushed a commit that referenced this pull request Dec 27, 2025
aviatesk added a commit that referenced this pull request Dec 29, 2025
Add a dependent module test

Add method scan

Implement recursive processing

The `PointWrapper` binding invalidation only happens when we re-evaluate
the constructor with the new binding for `Point`.

Broaden recursive processing

Fix type-change check, invokelatest

`Core._equiv_typedef` only checks the fieldnames, not their types.

Wrapping `eval_with_signatures` in `invokelatest` ensures that lowering will use the new binding resolutions.

Use subtyping for where constraints

delete debugging code

Perform type-comparisons after unwrapping

Unwrap before querying typename

Check equivalence recursively (fix recursive types)

Types like
```
struct Foo
    x::Vector{Foo}
end
```
were getting needlessly redefined.

Fix paths/cachefiles for stdlibs, Compiler

With the removal of some stdlibs, the corresponding cachefiles are no
longer in the base source cache.

The independent Compiler module also needs path fixes.

Increase `mtimedelay`

On fast systems the current setting is too aggressive

Disable tests: tracking CoreCompiler, coverage

For reasons not yet understood, tracking Core.Compiler deletes methods
for `NativeCompiler`.

The "misc - coverage" tests also fail in interactive mode
(`throwto_repl` errors, as it should, in interactive mode).

Improve the mtimedelay change

Avoid redefining types unless required

Improve method redefinition

improve struct revision tests

bootstrap the compiler if invalidated

Update to #918

Update to julia#58131

More mtimedelay tweaking

WSL was still flaky

Fix struct/const revise

Minor Recipes fix

Add aviatesk example

use `Core.methodtable` instead of `Core.GlobalMethod`

Don't call `Compiler.bootstrap!`

Fix 1.10

Force some precompilation

Restore & refine compiler revision

Undo bce9202, but track world ages to distinguish method redefinitions
triggered by Revise from those triggered by ordinary code loading.

More logging improvements

Add timing info, and show MethodSummary arrays.

Update to CodeTracking v2

Back out the test-package precompilaton

Was causing failures in extra tests

includet: avoid "prior to def. world" warning

Add test where field type changes

Fix primitive type comparison

add test with additional constructors

Fix custom constructors

Co-authored-by: Tim Holy <tim.holy@gmail.com>
aviatesk added a commit that referenced this pull request Dec 30, 2025
Add a dependent module test

Add method scan

Implement recursive processing

The `PointWrapper` binding invalidation only happens when we re-evaluate
the constructor with the new binding for `Point`.

Broaden recursive processing

Fix type-change check, invokelatest

`Core._equiv_typedef` only checks the fieldnames, not their types.

Wrapping `eval_with_signatures` in `invokelatest` ensures that lowering will use the new binding resolutions.

Use subtyping for where constraints

delete debugging code

Perform type-comparisons after unwrapping

Unwrap before querying typename

Check equivalence recursively (fix recursive types)

Types like
```
struct Foo
    x::Vector{Foo}
end
```
were getting needlessly redefined.

Fix paths/cachefiles for stdlibs, Compiler

With the removal of some stdlibs, the corresponding cachefiles are no
longer in the base source cache.

The independent Compiler module also needs path fixes.

Increase `mtimedelay`

On fast systems the current setting is too aggressive

Disable tests: tracking CoreCompiler, coverage

For reasons not yet understood, tracking Core.Compiler deletes methods
for `NativeCompiler`.

The "misc - coverage" tests also fail in interactive mode
(`throwto_repl` errors, as it should, in interactive mode).

Improve the mtimedelay change

Avoid redefining types unless required

Improve method redefinition

improve struct revision tests

bootstrap the compiler if invalidated

Update to #918

Update to julia#58131

More mtimedelay tweaking

WSL was still flaky

Fix struct/const revise

Minor Recipes fix

Add aviatesk example

use `Core.methodtable` instead of `Core.GlobalMethod`

Don't call `Compiler.bootstrap!`

Fix 1.10

Force some precompilation

Restore & refine compiler revision

Undo bce9202, but track world ages to distinguish method redefinitions
triggered by Revise from those triggered by ordinary code loading.

More logging improvements

Add timing info, and show MethodSummary arrays.

Update to CodeTracking v2

Back out the test-package precompilaton

Was causing failures in extra tests

includet: avoid "prior to def. world" warning

Add test where field type changes

Fix primitive type comparison

add test with additional constructors

Fix custom constructors

Co-authored-by: Tim Holy <tim.holy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant