Call "the_post" action to fix Visual Composer editor#958
Closed
felthy wants to merge 2 commits intotimber:masterfrom
Closed
Call "the_post" action to fix Visual Composer editor#958felthy wants to merge 2 commits intotimber:masterfrom
felthy wants to merge 2 commits intotimber:masterfrom
Conversation
Conflicts: lib/Post.php
Merged
|
Taken over by #969 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #957
Issue
Gets WPBakery Visual Composer front end editor working with Timber. See #957 for more detail.
Solution
Visual Composer uses the
'the_post' action hook to inject its inline editing anchors into the content; because the timber theme doesn't usethe_post()to render content, this action is not called. I added a call to the action to Timber.Impact
Minimal.
Usage
No change.
Considerations
This could also have been achieved by calling
setup_postdata($post);at the same line instead ofdo_actionbut I felt that callingdo_actionwould have fewer potential side effects.Testing
None - not sure how testing could be usefully automated for this issue. Also VC is not free.