2.x Update documentation for menus#2197
Conversation
jarednova
left a comment
There was a problem hiding this comment.
Looks good @gchtr. The one change I made was to make all of your examples with MenuPrimary and MenuItemPrimary. Before one of the examples before was using MenuFooter and MenuItemFooter, which took me a few minutes to decode. This way the examples are consistent in diff't pages throughout the documentation
Codecov Report
@@ Coverage Diff @@
## 2.x-docs-api #2197 +/- ##
===============================================
Coverage 96.04% 96.04%
Complexity 1530 1530
===============================================
Files 50 50
Lines 3892 3892
===============================================
Hits 3738 3738
Misses 154 154Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 2.x-docs-api #2197 +/- ##
===============================================
Coverage 94.18% 94.18%
Complexity 1615 1615
===============================================
Files 53 53
Lines 4079 4079
===============================================
Hits 3842 3842
Misses 237 237 Continue to review full report at Codecov.
|
Ticket: #2073, #2089
Menus aren’t documented yet in #2073. This pull request adds documentation for how menus are handled in 2.0.