Conversation
"Guest Authors" as returned from get_coauthors() are just stdclass objects, which are not supported in UserFactory. This adds support at the integration level to instantiate these as CoAuthorsPlusUser instances directly.
Doing this mainly for simplicity's sake, since the status of this integration is up in the air. Further discussion to be had on PR #2157.
This reverts commit f143bcd. This adds support for the Co-Authors Plus back in as it was when support was dropped. This is in case we decide to continue supporting it.
This matches up with WP Core and constitutes a non-breaking change. As a follow-up, we should still test passing different args for terms shared between taxonomies, and define exactly what those semantics are.
See also: #2087
|
Co-authored-by: Jared Novack <jarednova@upstatement.com>
Co-authored-by: Jared Novack <jarednova@upstatement.com>
…manually Favoring changes from 2.x-posts-api
2.x Update function signature for Term::posts()
|
I think we're good here @acobster @gchtr ? Unless there's something I'm missing I think we could pull this in and proceed with THE PURGE #2323. The only other PR to consider (at least that I saw) was #2293. Let me know if that needs to be resolved/merged first before we merge with #1617 or if it can come in after direct to 2.x |
|
There are a few other things noted in the checklist in #2073 (#2292, #1863, #2333) but these are all improvements on top of what I think is a pretty strong foundation here. We should also do a final pass over all the tests that are currently skipped at some point. And just for completeness's sake, #2073 still needs to be merge in, but I think that should come after those improvements. @szepeviktor where did you see that test failure? Travis seems happy... Barring any objections from @gchtr, I say let's go for it. |
That was 8 months ago 🐈 |
lol, is it Friday yet? |
|
@jarednova @acobster I’d say, let’s merge this in and then work on remaining tasks against the From what I can tell, #2073 still gives a very up-to-date view over the remaining tasks. I think apart from THE PURGE (#2323), these are mostly the only remaining blocking tasks that we need to work on before we could release an alpha or a beta version, right? While we can test the first version and resolve issues that might still surface there, we can also work on the other remaining tasks, like documentation, type declarations, etc. I can check for merge conflicts with #2073 once this pull request is merged into @acobster I’ll leave it to you to do the merge. |
|
Alright! Merging momentarily.
Yeah, I've done my best to keep #2073 up to date with everything we need to tackle before 2.0. And actually, IMO there's no reason we couldn't create an alpha release now. There will be one or two breaking changes thereafter (e.g. type declarations, PHP req), but that's what alpha releases are for 🙂 |
🎉 |
|
Now that's a merge! |
Let's have a PR for Factories.