Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #2127 +/- ##
======================================
Coverage ? 95.82%
Complexity ? 1526
======================================
Files ? 49
Lines ? 3904
Branches ? 0
======================================
Hits ? 3741
Misses ? 163
Partials ? 0
Continue to review full report at Codecov.
|
Member
|
@jarednova I have some thoughts about this and I started working on a separate guide to document how we should work with dates in Timber. I will have some spare time during my holidays to finish that guide and think about a solution for when to use the new |
Member
Author
|
sounds good @gchtr! I'll cool my jets on this for now then |
This was referenced Jan 2, 2020
Member
Author
|
Closing in favor of #2135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #2104
Issue
As @columbian-chris points out, there's some weird stuff happening when you use the
datefilter in certain circumstances. No wonder! We're overriding Twig's default behavior here in an attempt to better integrate WP behaviorSolution
Change the name of our custom filter from
date==>intl_dateImpact
This could break backwards compatibility, so making this a 2.x change
Usage Changes
Yes! Documented in the 2.x upgrade guide
Considerations
Should the name of the filter simply be
date_i18n? My fear is unless we're taking exactly the WP behavior, we shouldn't have the same name — thus,intl_dateis custom to Timber but something we can control even if in the future WP, Twig or PHP adopts new date/time internationalization behaviors.Testing
Existing tests will need to be updated to match default Twig
datefilter behavior