Merged
Conversation
added 4 commits
September 30, 2019 15:35
This replaces *most* instances of `new Timber\Post(...)` with calls to `Timber::get_post()`, which in the future will be the only way to instantiated Timber objects. The `Timber\Post` constructor will be made protected.
gchtr
reviewed
Oct 1, 2019
Member
gchtr
left a comment
There was a problem hiding this comment.
Cool! It’s great to see you jumping into this. 😎
3 tasks
added 4 commits
October 1, 2019 10:53
These were intended to test direct instantiation of Terms, which is going away.
Collaborator
Author
|
@gchtr any more feedback before I merge this in? |
dd50043 to
76a5427
Compare
added 2 commits
October 3, 2019 12:21
Member
|
@gchtr are you sure you meant to close this issue? |
Member
|
Nope, I didn’t. For the documentation in #2073, I first created a |
gchtr
approved these changes
Jan 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #1793
Issue
We're moving to a new API that will restrict direct instantiation of core Timber objects (
Post,User,Menu, etc.) in favor of correspondingTimber::get_*calls.Solution
This refactors away most direct instantiations within the tests. Some refactors we'll need to do eventually are impossible right now, since the
Timberclass lacks someget_*methods we'll need to replace the calls with. I don't want to add any code just yet, so I'm just taking care of the low hanging fruit right now.Impact
None.
Usage Changes
No changes to production code in this PR; only tests.
Considerations
???
Testing
You know I'm all about those tests tho.