Travis tests are still failing (though they pass on my local); please hold off on any review/merge until I can resolve

Looks like those failing tests are now resolved (good thing they failed, helped me to identify a bug that this created related to a MenuItem's depth!). Would love another set of 👀 on this ...

Codecov Report

Merging #2083 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2083      +/-   ##
============================================
+ Coverage     95.05%   95.06%   +<.01%     
- Complexity     1579     1580       +1     
============================================
  Files            50       50              
  Lines          3744     3746       +2     
============================================
+ Hits           3559     3561       +2     
  Misses          185      185

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e5e87...cbaa1b9. Read the comment docs.

Coverage decreased (-0.2%) to 93.614% when pulling 90cac55 on 2071/menu_recursion into ca46f19 on master.

Coverage increased (+0.06%) to 93.888% when pulling 90cac55 on 2071/menu_recursion into ca46f19 on master.

@gchtr thanks for your feedback, back to you! Just a few tweaks were needed to take care of those items

@jarednova Thanks for the changes!

Instead, could we add a deprecation call to a __get() method, that checks if the protected $menu property is accessed?

I’m assuming you don’t want to catch direct calls to MenuItem::$menu then?

@gchtr actually, it turns out we get that already w/o any modification to __get() ....

I wrote this test to validate (which passes):

function testMenuItemMenuProperty() {
		$pg_1 = $this->factory->post->create( array( 'post_type' => 'page', 'post_title' => 'Foo Page', 'menu_order' => 10 ) );
		$pg_2 = $this->factory->post->create( array( 'post_type' => 'page', 'post_title' => 'Bar Page', 'menu_order' => 1 ) );
		$page_menu = new Timber\Menu();
		$items = $page_menu->get_items();
		$menu = $items[0]->menu;
		$this->assertEquals('Timber\Menu', get_class($menu));
	}

... the logic in __get() looks for methods with that name and already uses them instead of properties.

@jarednova Oh, I see! Very well then. Let’s merge this in!