Assign aerodrome kind_detail to runways.#1854
Merged
zerebubuth merged 1 commit intomasterfrom Mar 18, 2019
Merged
Conversation
Aerodrome polygons are (usually) used to map the footprint of an airport, and often have an `aerodrome:type` tag to indicate whether it's an international or domestic airport. We added that as `kind_detail` in #1277, but it's useful to know that information on runways also. This allows us to hide runways of smaller airports and emphasise those of bigger (international) ones. This extends the intercut / overlap methods to add "where" clauses, so that we can select those features within the layer which are being cut or used for cutting. We can then overlap the aerodrome polygons with the runways (lines in `roads` layer, polygons in `landuse`) to assign the `kind_detail`. Worth noting; we already had a `kind_detail` on the runway lines in the `roads` layer, so I've called this new attribute `aerodrome_kind_detail` instead.
rmarianski
approved these changes
Mar 15, 2019
This was referenced Apr 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aerodrome polygons are (usually) used to map the footprint of an airport, and often have an
aerodrome:typetag to indicate whether it's an international or domestic airport. We added that askind_detailin #1277 to the aerodrome polygons, but it's useful to know that information on runways also. This allows us to hide runways of smaller airports and emphasise those of bigger (international) ones.This extends the intercut / overlap methods to add "where" clauses, so that we can select those features within the layer which are being cut or used for cutting. We can then overlap the aerodrome polygons with the runways (lines in
roadslayer, polygons inlanduse) to assign thekind_detail.Worth noting; we already had a
kind_detailon the runway lines in theroadslayer, so I've called this new attributeaerodrome_kind_detailinstead.Connects to #1852.