Remove unused wooded area tags + natural=park and add leaf_type to wooded areas#1459
Merged
nvkelso merged 1 commit intotilezen:masterfrom Dec 26, 2017
Merged
Remove unused wooded area tags + natural=park and add leaf_type to wooded areas#1459nvkelso merged 1 commit intotilezen:masterfrom
nvkelso merged 1 commit intotilezen:masterfrom
Conversation
nvkelso
reviewed
Dec 21, 2017
| output: | ||
| <<: *output_properties | ||
| kind: forest | ||
| kind_detail: *woods_detail |
Member
There was a problem hiding this comment.
While this may be technically correct YAML, it's doesn't follow our convention.
Instead of declaring the YAML global on line 342 with kind_detail: &woods_detail { col: leaf_type } instead add to the globals section around line 134 like:
- &leaftype_kind_detail
kind_detail: { col: leaf_type }
and then the usage down below (like 342, 349, etc) would be:
<<: * leaftype_kind_detail
nvkelso
previously requested changes
Dec 21, 2017
| * `military` | ||
| * `national_park` | ||
| * `nature_reserve` | ||
| * `natural_forest` - _See planned bug fix in [#1096](https://github.com/tilezen/vector-datasource/issues/1096)._ |
Member
There was a problem hiding this comment.
Please revert these changes for natural_forest and natural_park throughout this PR, and add the leaf type kind_detail to both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
natural=forest, landuse=wood and natural=park are all mistakes with about 0.02% occurrence in the data.This isn't a schema-breaking change because these objects aren't present except as mistakes anyways.I did this change first because I had to modify all the wooded areas for the other change, leaf_type. This adds the leaf_type to kind_detail for wooded areas.