Remove natural=park, natural=forest, and landuse=wood#1469
Closed
pnorman wants to merge 1 commit intotilezen:masterfrom
Closed
Remove natural=park, natural=forest, and landuse=wood#1469pnorman wants to merge 1 commit intotilezen:masterfrom
pnorman wants to merge 1 commit intotilezen:masterfrom
Conversation
All three are tagging errors that occur very infrequently. The first occurs at a 0.022% rate and the latter two at a 0.017% rate in current OSM data.
3 tasks
Member
|
This relates to #1096 but instead of setting sort_rank it removes the features entirely, which would trigger a major version increment per https://github.com/tilezen/vector-datasource/blob/master/SEMANTIC-VERSIONING.md#major-version-increments. I'm not opposed to that – since it's a breaking change we stash them for later. Short term we should just fix the bug in #1096. |
Member
|
Closing PR but tracking future breaking change work in #1544. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All three are tagging errors that occur very infrequently. The first occurs at a 0.022% rate and the latter two at a 0.017% rate in current OSM data.